Skip to content

feat(profiling): add threading.RLock support to the Lock profiler (re-entrant lock) #14823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 24, 2025
Merged

feat(profiling): add threading.RLock support to the Lock profiler (re-entrant lock) #14823

merged 22 commits into from
Oct 24, 2025

Conversation

@vlad-scherbich
Copy link
Contributor

@vlad-scherbich vlad-scherbich commented Oct 9, 2025 •
edited by atlassian bot
Loading

PROF-12721

Description

This PR adds profiling support for a new kind of synchronization mechanism: Reentrant Lock. A RLock is a lock that can be acquired by the same thread multiple times without blocking on itself. From the documentation:

Once a thread has acquired a reentrant lock, the same thread may acquire it again without blocking; the thread must release it once for each time it has acquired it.

This feature was identified as one of the most - low-hanging-fruits, since RLocks are being used extensively in Python world.

Changes

  • added new ThreadingRLockCollector class in threading.py
  • register the new collector in Profiler in profiler.py
  • current test_threading.py module has been updated to reuse existing tests for both Lock and RLock primitives (via new inheritance)
  • test_global_locks test rewritten extensively to support the unit test code reuse between Lock and RLock (effectively duplicating the existing extensive Lock unit tests for RLock ... without the code duplication)

Testing

  • added new unit tests
  • added new e2e test:
  • Reentrant behavior works for multi-level acquisition
  • Thread contention handling validated

Risks

none

Additional Notes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

releasenotes/notes/feat-profiling-rlock-support-e8607e68252647.yaml     @DataDog/apm-python
ddtrace/profiling/collector/threading.py                                @DataDog/profiling-python
ddtrace/profiling/profiler.py                                           @DataDog/profiling-python
tests/profiling_v2/collector/test_threading.py                          @DataDog/profiling-python
tests/profiling_v2/test_profiler.py                                     @DataDog/profiling-python
tests/profiling/collector/global_locks.py                               @DataDog/profiling-python

@vlad-scherbich vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 2 times, most recently from 944b340 to c17cd90 Compare October 9, 2025 03:00
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025 •
edited
Loading

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 249 ± 5 ms.

The average import time from base is: 251 ± 6 ms.

The import time difference between this PR and base is: -2.0 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.989 ms (0.80%)
ddtrace.bootstrap.sitecustomize 1.302 ms (0.52%)
ddtrace.bootstrap.preload 1.302 ms (0.52%)
ddtrace.internal.remoteconfig.client 0.646 ms (0.26%)
ddtrace 0.687 ms (0.28%)
ddtrace.internal._unpatched 0.031 ms (0.01%)
json 0.031 ms (0.01%)
json.decoder 0.031 ms (0.01%)
re 0.031 ms (0.01%)
enum 0.031 ms (0.01%)
types 0.031 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Oct 9, 2025 •
edited
Loading

Performance SLOs

Comparing candidate vlad/lock-profiler-add-rlock (1db7591) with baseline main (b433817)

🟡 Near SLO Breach (4 suites)
🟡 djangosimple - 30/30

✅ appsec

Time: ✅ 20.489ms (SLO: <22.300ms -8.1%) vs baseline: +0.4%

Memory: ✅ 65.259MB (SLO: <67.000MB -2.6%) vs baseline: +4.9%

✅ exception-replay-enabled

Time: ✅ 1.345ms (SLO: <1.450ms -7.2%) vs baseline: +0.2%

Memory: ✅ 64.601MB (SLO: <67.000MB -3.6%) vs baseline: +4.8%

✅ iast

Time: ✅ 20.409ms (SLO: <22.250ms -8.3%) vs baseline: -0.1%

Memory: ✅ 65.245MB (SLO: <67.000MB -2.6%) vs baseline: +5.0%

✅ profiler

Time: ✅ 15.537ms (SLO: <16.550ms -6.1%) vs baseline: +1.9%

Memory: ✅ 53.772MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +4.9%

✅ resource-renaming

Time: ✅ 20.605ms (SLO: <21.750ms -5.3%) vs baseline: +0.5%

Memory: ✅ 65.197MB (SLO: <67.000MB -2.7%) vs baseline: +4.9%

✅ span-code-origin

Time: ✅ 25.052ms (SLO: <28.200ms 📉 -11.2%) vs baseline: -1.7%

Memory: ✅ 67.854MB (SLO: <69.500MB -2.4%) vs baseline: +5.0%

✅ tracer

Time: ✅ 20.438ms (SLO: <21.750ms -6.0%) vs baseline: ~same

Memory: ✅ 65.216MB (SLO: <67.000MB -2.7%) vs baseline: +4.9%

✅ tracer-and-profiler

Time: ✅ 22.709ms (SLO: <23.500ms -3.4%) vs baseline: +3.3%

Memory: ✅ 66.765MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.1%

✅ tracer-dont-create-db-spans

Time: ✅ 19.361ms (SLO: <21.500ms -9.9%) vs baseline: ~same

Memory: ✅ 65.235MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.9%

✅ tracer-minimal

Time: ✅ 16.652ms (SLO: <17.500ms -4.8%) vs baseline: ~same

Memory: ✅ 65.233MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.9%

✅ tracer-native

Time: ✅ 20.451ms (SLO: <21.750ms -6.0%) vs baseline: ~same

Memory: ✅ 71.133MB (SLO: <72.500MB 🟡 -1.9%) vs baseline: +4.7%

✅ tracer-no-caches

Time: ✅ 18.496ms (SLO: <19.650ms -5.9%) vs baseline: +0.3%

Memory: ✅ 65.201MB (SLO: <67.000MB -2.7%) vs baseline: +4.9%

✅ tracer-no-databases

Time: ✅ 18.729ms (SLO: <20.100ms -6.8%) vs baseline: -0.1%

Memory: ✅ 65.201MB (SLO: <67.000MB -2.7%) vs baseline: +4.8%

✅ tracer-no-middleware

Time: ✅ 20.189ms (SLO: <21.500ms -6.1%) vs baseline: +0.2%

Memory: ✅ 65.220MB (SLO: <67.000MB -2.7%) vs baseline: +4.9%

✅ tracer-no-templates

Time: ✅ 20.247ms (SLO: <22.000ms -8.0%) vs baseline: -0.1%

Memory: ✅ 65.198MB (SLO: <67.000MB -2.7%) vs baseline: +4.8%

🟡 errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 18.072ms (SLO: <19.850ms -9.0%) vs baseline: +0.3%

Memory: ✅ 65.140MB (SLO: <66.500MB -2.0%) vs baseline: +4.8%

✅ errortracking-enabled-user

Time: ✅ 18.056ms (SLO: <19.400ms -6.9%) vs baseline: ~same

Memory: ✅ 65.115MB (SLO: <66.500MB -2.1%) vs baseline: +4.9%

✅ tracer-enabled

Time: ✅ 17.962ms (SLO: <19.450ms -7.7%) vs baseline: -0.3%

Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8%

🟡 flasksimple - 18/18

✅ appsec-get

Time: ✅ 4.575ms (SLO: <4.750ms -3.7%) vs baseline: -0.5%

Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +5.0%

✅ appsec-post

Time: ✅ 6.604ms (SLO: <6.750ms -2.2%) vs baseline: -0.3%

Memory: ✅ 61.932MB (SLO: <65.000MB -4.7%) vs baseline: +4.6%

✅ appsec-telemetry

Time: ✅ 4.580ms (SLO: <4.750ms -3.6%) vs baseline: -0.4%

Memory: ✅ 61.985MB (SLO: <65.000MB -4.6%) vs baseline: +4.9%

✅ debugger

Time: ✅ 1.859ms (SLO: <2.000ms -7.1%) vs baseline: -0.2%

Memory: ✅ 45.416MB (SLO: <47.000MB -3.4%) vs baseline: +4.9%

✅ iast-get

Time: ✅ 1.862ms (SLO: <2.000ms -6.9%) vs baseline: -0.4%

Memory: ✅ 42.389MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +5.1%

✅ profiler

Time: ✅ 1.910ms (SLO: <2.100ms -9.0%) vs baseline: -0.3%

Memory: ✅ 46.537MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +4.8%

✅ resource-renaming

Time: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: -0.3%

Memory: ✅ 52.370MB (SLO: <53.500MB -2.1%) vs baseline: +5.0%

✅ tracer

Time: ✅ 3.356ms (SLO: <3.650ms -8.0%) vs baseline: -0.2%

Memory: ✅ 52.278MB (SLO: <53.500MB -2.3%) vs baseline: +4.9%

✅ tracer-native

Time: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: +0.1%

Memory: ✅ 58.317MB (SLO: <60.000MB -2.8%) vs baseline: +4.9%

🟡 telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 2.936µs (SLO: <20.000µs 📉 -85.3%) vs baseline: -0.4%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.6%

✅ 1-count-metrics-100-times

Time: ✅ 203.683µs (SLO: <220.000µs -7.4%) vs baseline: +0.9%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9%

✅ 1-distribution-metric-1-times

Time: ✅ 3.321µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +0.7%

Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.2%

✅ 1-distribution-metrics-100-times

Time: ✅ 213.446µs (SLO: <220.000µs -3.0%) vs baseline: -0.3%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.6%

✅ 1-gauge-metric-1-times

Time: ✅ 2.241µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +1.0%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7%

✅ 1-gauge-metrics-100-times

Time: ✅ 137.935µs (SLO: <150.000µs -8.0%) vs baseline: +0.2%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.5%

✅ 1-rate-metric-1-times

Time: ✅ 3.256µs (SLO: <20.000µs 📉 -83.7%) vs baseline: +6.4%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ 1-rate-metrics-100-times

Time: ✅ 217.010µs (SLO: <250.000µs 📉 -13.2%) vs baseline: +0.5%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ 100-count-metrics-100-times

Time: ✅ 20.603ms (SLO: <22.000ms -6.4%) vs baseline: +1.0%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7%

✅ 100-distribution-metrics-100-times

Time: ✅ 2.287ms (SLO: <2.300ms 🟡 -0.6%) vs baseline: +0.4%

Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +4.8%

✅ 100-gauge-metrics-100-times

Time: ✅ 1.407ms (SLO: <1.550ms -9.2%) vs baseline: -0.4%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.0%

✅ 100-rate-metrics-100-times

Time: ✅ 2.226ms (SLO: <2.550ms 📉 -12.7%) vs baseline: -0.5%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.0%

✅ flush-1-metric

Time: ✅ 4.562µs (SLO: <20.000µs 📉 -77.2%) vs baseline: +3.0%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9%

✅ flush-100-metrics

Time: ✅ 173.957µs (SLO: <250.000µs 📉 -30.4%) vs baseline: ~same

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.7%

✅ flush-1000-metrics

Time: ✅ 2.112ms (SLO: <2.500ms 📉 -15.5%) vs baseline: -0.8%

Memory: ✅ 32.893MB (SLO: <34.500MB -4.7%) vs baseline: +4.7%

⚠️ Unstable Tests (1 suite)
⚠️ coreapiscenario - 10/10 (1 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.274µs (SLO: <20.000µs 📉 -33.6%) vs baseline: +0.2%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +5.1%

✅ context_with_data_no_listeners

Time: ✅ 3.320µs (SLO: <10.000µs 📉 -66.8%) vs baseline: +2.1%

Memory: ✅ 32.067MB (SLO: <33.500MB -4.3%) vs baseline: +4.5%

✅ get_item_exists

Time: ✅ 0.583µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.4%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ get_item_missing

Time: ✅ 0.630µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.3%

Memory: ✅ 32.106MB (SLO: <33.500MB -4.2%) vs baseline: +4.9%

✅ set_item

Time: ✅ 24.247µs (SLO: <30.000µs 📉 -19.2%) vs baseline: +1.3%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +5.0%

✅ All Tests Passing (19 suites)
✅ errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.066ms (SLO: <2.300ms 📉 -10.2%) vs baseline: -0.2%

Memory: ✅ 52.140MB (SLO: <53.500MB -2.5%) vs baseline: +4.9%

✅ errortracking-enabled-user

Time: ✅ 2.070ms (SLO: <2.250ms -8.0%) vs baseline: -0.2%

Memory: ✅ 52.121MB (SLO: <53.500MB -2.6%) vs baseline: +4.7%

✅ tracer-enabled

Time: ✅ 2.065ms (SLO: <2.300ms 📉 -10.2%) vs baseline: -0.6%

Memory: ✅ 52.199MB (SLO: <53.500MB -2.4%) vs baseline: +4.9%

✅ flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 3.959ms (SLO: <4.200ms -5.7%) vs baseline: -0.3%

Memory: ✅ 62.285MB (SLO: <66.000MB -5.6%) vs baseline: +4.9%

✅ iast-enabled

Time: ✅ 2.434ms (SLO: <2.800ms 📉 -13.1%) vs baseline: -0.3%

Memory: ✅ 58.629MB (SLO: <60.000MB -2.3%) vs baseline: +4.8%

✅ tracer-enabled

Time: ✅ 2.053ms (SLO: <2.250ms -8.7%) vs baseline: -0.4%

Memory: ✅ 52.278MB (SLO: <54.500MB -4.1%) vs baseline: +5.2%

✅ httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 81.569µs (SLO: <100.000µs 📉 -18.4%) vs baseline: +0.6%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ b3_headers

Time: ✅ 14.267µs (SLO: <20.000µs 📉 -28.7%) vs baseline: +0.3%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ b3_single_headers

Time: ✅ 13.253µs (SLO: <20.000µs 📉 -33.7%) vs baseline: ~same

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 63.783µs (SLO: <80.000µs 📉 -20.3%) vs baseline: +0.1%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 66.168µs (SLO: <80.000µs 📉 -17.3%) vs baseline: +0.2%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ empty_headers

Time: ✅ 1.608µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.6%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ full_t_id_datadog_headers

Time: ✅ 22.853µs (SLO: <30.000µs 📉 -23.8%) vs baseline: +0.5%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ invalid_priority_header

Time: ✅ 6.536µs (SLO: <10.000µs 📉 -34.6%) vs baseline: -0.6%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ invalid_span_id_header

Time: ✅ 6.603µs (SLO: <10.000µs 📉 -34.0%) vs baseline: +0.9%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ invalid_tags_header

Time: ✅ 6.555µs (SLO: <10.000µs 📉 -34.4%) vs baseline: +0.8%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ invalid_trace_id_header

Time: ✅ 6.606µs (SLO: <10.000µs 📉 -33.9%) vs baseline: +0.3%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ large_header_no_matches

Time: ✅ 27.593µs (SLO: <30.000µs -8.0%) vs baseline: ~same

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.6%

✅ large_valid_headers_all

Time: ✅ 28.812µs (SLO: <40.000µs 📉 -28.0%) vs baseline: +0.4%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ medium_header_no_matches

Time: ✅ 9.886µs (SLO: <20.000µs 📉 -50.6%) vs baseline: ~same

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ medium_valid_headers_all

Time: ✅ 11.343µs (SLO: <20.000µs 📉 -43.3%) vs baseline: +0.7%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ none_propagation_style

Time: ✅ 1.713µs (SLO: <10.000µs 📉 -82.9%) vs baseline: +0.7%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ tracecontext_headers

Time: ✅ 34.490µs (SLO: <40.000µs 📉 -13.8%) vs baseline: ~same

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ valid_headers_all

Time: ✅ 6.565µs (SLO: <10.000µs 📉 -34.3%) vs baseline: +0.2%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ valid_headers_basic

Time: ✅ 6.147µs (SLO: <10.000µs 📉 -38.5%) vs baseline: +0.5%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ wsgi_empty_headers

Time: ✅ 1.605µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.2%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_invalid_priority_header

Time: ✅ 6.637µs (SLO: <10.000µs 📉 -33.6%) vs baseline: ~same

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_invalid_span_id_header

Time: ✅ 1.621µs (SLO: <10.000µs 📉 -83.8%) vs baseline: +1.1%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ wsgi_invalid_tags_header

Time: ✅ 6.604µs (SLO: <10.000µs 📉 -34.0%) vs baseline: ~same

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ wsgi_invalid_trace_id_header

Time: ✅ 6.652µs (SLO: <10.000µs 📉 -33.5%) vs baseline: +0.6%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ wsgi_large_header_no_matches

Time: ✅ 28.681µs (SLO: <40.000µs 📉 -28.3%) vs baseline: -0.7%

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.7%

✅ wsgi_large_valid_headers_all

Time: ✅ 29.791µs (SLO: <40.000µs 📉 -25.5%) vs baseline: -0.2%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ wsgi_medium_header_no_matches

Time: ✅ 10.086µs (SLO: <20.000µs 📉 -49.6%) vs baseline: -0.5%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +5.1%

✅ wsgi_medium_valid_headers_all

Time: ✅ 11.579µs (SLO: <20.000µs 📉 -42.1%) vs baseline: +0.7%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ wsgi_valid_headers_all

Time: ✅ 6.584µs (SLO: <10.000µs 📉 -34.2%) vs baseline: +0.3%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_valid_headers_basic

Time: ✅ 6.155µs (SLO: <10.000µs 📉 -38.5%) vs baseline: +0.8%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ httppropagationinject - 16/16

✅ ids_only

Time: ✅ 22.262µs (SLO: <30.000µs 📉 -25.8%) vs baseline: +3.6%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ with_all

Time: ✅ 28.812µs (SLO: <40.000µs 📉 -28.0%) vs baseline: ~same

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ with_dd_origin

Time: ✅ 25.252µs (SLO: <30.000µs 📉 -15.8%) vs baseline: -0.5%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ with_priority_and_origin

Time: ✅ 24.869µs (SLO: <40.000µs 📉 -37.8%) vs baseline: +0.6%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.9%

✅ with_sampling_priority

Time: ✅ 21.500µs (SLO: <30.000µs 📉 -28.3%) vs baseline: ~same

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ with_tags

Time: ✅ 27.937µs (SLO: <40.000µs 📉 -30.2%) vs baseline: +3.5%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ with_tags_invalid

Time: ✅ 29.558µs (SLO: <40.000µs 📉 -26.1%) vs baseline: +3.8%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ with_tags_max_size

Time: ✅ 27.320µs (SLO: <40.000µs 📉 -31.7%) vs baseline: ~same

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ iast_aspects - 40/40

✅ re_expand_aspect

Time: ✅ 31.896µs (SLO: <40.000µs 📉 -20.3%) vs baseline: +0.1%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ re_expand_noaspect

Time: ✅ 28.702µs (SLO: <40.000µs 📉 -28.2%) vs baseline: ~same

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_findall_aspect

Time: ✅ 2.901µs (SLO: <10.000µs 📉 -71.0%) vs baseline: +0.4%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ re_findall_noaspect

Time: ✅ 1.415µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.5%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ re_finditer_aspect

Time: ✅ 4.440µs (SLO: <10.000µs 📉 -55.6%) vs baseline: -0.1%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ re_finditer_noaspect

Time: ✅ 1.405µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.8%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.2%

✅ re_fullmatch_aspect

Time: ✅ 2.647µs (SLO: <10.000µs 📉 -73.5%) vs baseline: -0.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ re_fullmatch_noaspect

Time: ✅ 1.275µs (SLO: <10.000µs 📉 -87.3%) vs baseline: -2.0%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ re_group_aspect

Time: ✅ 2.911µs (SLO: <10.000µs 📉 -70.9%) vs baseline: -0.9%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ re_group_noaspect

Time: ✅ 1.618µs (SLO: <10.000µs 📉 -83.8%) vs baseline: -0.2%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ re_groups_aspect

Time: ✅ 3.274µs (SLO: <10.000µs 📉 -67.3%) vs baseline: +6.2%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7%

✅ re_groups_noaspect

Time: ✅ 1.691µs (SLO: <10.000µs 📉 -83.1%) vs baseline: +0.1%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ re_match_aspect

Time: ✅ 2.705µs (SLO: <10.000µs 📉 -73.0%) vs baseline: +0.6%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ re_match_noaspect

Time: ✅ 1.300µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.1%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ re_search_aspect

Time: ✅ 2.672µs (SLO: <10.000µs 📉 -73.3%) vs baseline: +4.4%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_search_noaspect

Time: ✅ 1.210µs (SLO: <10.000µs 📉 -87.9%) vs baseline: +0.4%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ re_sub_aspect

Time: ✅ 3.603µs (SLO: <10.000µs 📉 -64.0%) vs baseline: +5.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_sub_noaspect

Time: ✅ 1.536µs (SLO: <10.000µs 📉 -84.6%) vs baseline: ~same

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7%

✅ re_subn_aspect

Time: ✅ 3.826µs (SLO: <10.000µs 📉 -61.7%) vs baseline: +4.2%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.9%

✅ re_subn_noaspect

Time: ✅ 1.628µs (SLO: <10.000µs 📉 -83.7%) vs baseline: +0.9%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ iastaspects - 118/118

✅ add_aspect

Time: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.1%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ add_inplace_aspect

Time: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.2%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ add_inplace_noaspect

Time: ✅ 0.319µs (SLO: <10.000µs 📉 -96.8%) vs baseline: ~same

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ add_noaspect

Time: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.0%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ bytearray_aspect

Time: ✅ 1.338µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.6%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ bytearray_extend_aspect

Time: ✅ 1.526µs (SLO: <10.000µs 📉 -84.7%) vs baseline: ~same

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.0%

✅ bytearray_extend_noaspect

Time: ✅ 0.613µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.5%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6%

✅ bytearray_noaspect

Time: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.3%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ bytes_aspect

Time: ✅ 1.289µs (SLO: <10.000µs 📉 -87.1%) vs baseline: +0.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.4%

✅ bytes_noaspect

Time: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.0%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ bytesio_aspect

Time: ✅ 1.341µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.4%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ bytesio_noaspect

Time: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.2%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.0%

✅ capitalize_aspect

Time: ✅ 0.736µs (SLO: <10.000µs 📉 -92.6%) vs baseline: ~same

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ capitalize_noaspect

Time: ✅ 0.437µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.9%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7%

✅ casefold_aspect

Time: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ casefold_noaspect

Time: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: ~same

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ decode_aspect

Time: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +1.2%

Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.4%

✅ decode_noaspect

Time: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.1%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ encode_aspect

Time: ✅ 0.709µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.2%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ encode_noaspect

Time: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.7%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ format_aspect

Time: ✅ 3.375µs (SLO: <10.000µs 📉 -66.3%) vs baseline: +0.7%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6%

✅ format_map_aspect

Time: ✅ 3.562µs (SLO: <10.000µs 📉 -64.4%) vs baseline: +0.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ format_map_noaspect

Time: ✅ 0.776µs (SLO: <10.000µs 📉 -92.2%) vs baseline: -0.3%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ format_noaspect

Time: ✅ 0.598µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.4%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ index_aspect

Time: ✅ 0.361µs (SLO: <10.000µs 📉 -96.4%) vs baseline: ~same

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ index_noaspect

Time: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: ~same

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ join_aspect

Time: ✅ 1.333µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.2%

✅ join_noaspect

Time: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.2%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ ljust_aspect

Time: ✅ 2.624µs (SLO: <20.000µs 📉 -86.9%) vs baseline: +0.5%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

✅ ljust_noaspect

Time: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.4%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ lower_aspect

Time: ✅ 2.257µs (SLO: <10.000µs 📉 -77.4%) vs baseline: +0.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ lower_noaspect

Time: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.5%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ lstrip_aspect

Time: ✅ 2.217µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +1.1%

Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +4.7%

✅ lstrip_noaspect

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.1%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ modulo_aspect

Time: ✅ 1.000µs (SLO: <10.000µs 📉 -90.0%) vs baseline: -0.6%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.5%

✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.543µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +0.5%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ modulo_aspect_for_bytes

Time: ✅ 0.977µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.5%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +3.7%

✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.211µs (SLO: <10.000µs 📉 -87.9%) vs baseline: +1.2%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +3.6%

✅ modulo_noaspect

Time: ✅ 0.632µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ replace_aspect

Time: ✅ 4.858µs (SLO: <10.000µs 📉 -51.4%) vs baseline: +0.9%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ replace_noaspect

Time: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ repr_aspect

Time: ✅ 0.911µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.5%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.5%

✅ repr_noaspect

Time: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.7%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ rstrip_aspect

Time: ✅ 1.930µs (SLO: <20.000µs 📉 -90.3%) vs baseline: +0.4%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.1%

✅ rstrip_noaspect

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ slice_aspect

Time: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.5%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ slice_noaspect

Time: ✅ 0.446µs (SLO: <10.000µs 📉 -95.5%) vs baseline: ~same

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ stringio_aspect

Time: ✅ 1.636µs (SLO: <10.000µs 📉 -83.6%) vs baseline: +5.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ stringio_noaspect

Time: ✅ 0.710µs (SLO: <10.000µs 📉 -92.9%) vs baseline: ~same

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ strip_aspect

Time: ✅ 2.219µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.5%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ strip_noaspect

Time: ✅ 0.390µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +1.1%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.8%

✅ swapcase_aspect

Time: ✅ 2.451µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +0.2%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ swapcase_noaspect

Time: ✅ 0.535µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.7%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ title_aspect

Time: ✅ 2.395µs (SLO: <10.000µs 📉 -76.0%) vs baseline: -1.7%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ title_noaspect

Time: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.6%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ translate_aspect

Time: ✅ 3.284µs (SLO: <10.000µs 📉 -67.2%) vs baseline: +0.2%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ translate_noaspect

Time: ✅ 1.036µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.5%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ upper_aspect

Time: ✅ 2.272µs (SLO: <10.000µs 📉 -77.3%) vs baseline: +0.8%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ upper_noaspect

Time: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.1%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 4.284µs (SLO: <10.000µs 📉 -57.2%) vs baseline: -0.5%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ ospathbasename_noaspect

Time: ✅ 1.090µs (SLO: <10.000µs 📉 -89.1%) vs baseline: -0.3%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ ospathjoin_aspect

Time: ✅ 6.235µs (SLO: <10.000µs 📉 -37.7%) vs baseline: ~same

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ ospathjoin_noaspect

Time: ✅ 2.293µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.6%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ ospathnormcase_aspect

Time: ✅ 3.603µs (SLO: <10.000µs 📉 -64.0%) vs baseline: +1.1%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ ospathnormcase_noaspect

Time: ✅ 0.575µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -2.1%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ ospathsplit_aspect

Time: ✅ 4.929µs (SLO: <10.000µs 📉 -50.7%) vs baseline: -0.1%

Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.5%

✅ ospathsplit_noaspect

Time: ✅ 1.604µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.3%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7%

✅ ospathsplitdrive_aspect

Time: ✅ 3.751µs (SLO: <10.000µs 📉 -62.5%) vs baseline: -0.4%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ ospathsplitdrive_noaspect

Time: ✅ 0.701µs (SLO: <10.000µs 📉 -93.0%) vs baseline: ~same

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ ospathsplitext_aspect

Time: ✅ 4.614µs (SLO: <10.000µs 📉 -53.9%) vs baseline: ~same

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ ospathsplitext_noaspect

Time: ✅ 1.393µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -0.6%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 1.390µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -1.0%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ rsplit_noaspect

Time: ✅ 0.578µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -1.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ split_aspect

Time: ✅ 1.393µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

✅ split_noaspect

Time: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: ~same

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ splitlines_aspect

Time: ✅ 1.363µs (SLO: <10.000µs 📉 -86.4%) vs baseline: -2.9%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ splitlines_noaspect

Time: ✅ 0.582µs (SLO: <10.000µs 📉 -94.2%) vs baseline: ~same

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ iastpropagation - 2/2

✅ no-propagation

Time: ✅ 49.471µs (SLO: <60.000µs 📉 -17.5%) vs baseline: +0.3%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.304ms (SLO: <42.000ms -4.0%) vs baseline: -0.1%

Memory: ✅ 34.623MB (SLO: <39.000MB 📉 -11.2%) vs baseline: +4.1%

✅ add-link

Time: ✅ 36.328ms (SLO: <38.550ms -5.8%) vs baseline: ~same

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +3.6%

✅ add-metrics

Time: ✅ 218.853ms (SLO: <232.000ms -5.7%) vs baseline: -0.5%

Memory: ✅ 34.859MB (SLO: <39.000MB 📉 -10.6%) vs baseline: +4.8%

✅ add-tags

Time: ✅ 211.256ms (SLO: <221.600ms -4.7%) vs baseline: ~same

Memory: ✅ 34.465MB (SLO: <39.000MB 📉 -11.6%) vs baseline: +3.4%

✅ get-context

Time: ✅ 29.141ms (SLO: <31.300ms -6.9%) vs baseline: +0.1%

Memory: ✅ 34.505MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +3.6%

✅ is-recording

Time: ✅ 29.185ms (SLO: <31.000ms -5.9%) vs baseline: -0.2%

Memory: ✅ 34.505MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +3.6%

✅ record-exception

Time: ✅ 63.163ms (SLO: <65.850ms -4.1%) vs baseline: -0.2%

Memory: ✅ 34.957MB (SLO: <39.000MB 📉 -10.4%) vs baseline: +5.2%

✅ set-status

Time: ✅ 31.993ms (SLO: <34.150ms -6.3%) vs baseline: +0.3%

Memory: ✅ 34.662MB (SLO: <39.000MB 📉 -11.1%) vs baseline: +4.0%

✅ start

Time: ✅ 28.758ms (SLO: <30.150ms -4.6%) vs baseline: -0.5%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +3.6%

✅ start-finish

Time: ✅ 34.000ms (SLO: <35.350ms -3.8%) vs baseline: -0.2%

Memory: ✅ 34.583MB (SLO: <39.000MB 📉 -11.3%) vs baseline: +3.9%

✅ start-finish-telemetry

Time: ✅ 33.825ms (SLO: <35.450ms -4.6%) vs baseline: -0.8%

Memory: ✅ 34.839MB (SLO: <39.000MB 📉 -10.7%) vs baseline: +4.8%

✅ update-name

Time: ✅ 31.024ms (SLO: <33.400ms -7.1%) vs baseline: +0.3%

Memory: ✅ 34.662MB (SLO: <39.000MB 📉 -11.1%) vs baseline: +4.3%

✅ otelspan - 22/22

✅ add-event

Time: ✅ 40.463ms (SLO: <47.150ms 📉 -14.2%) vs baseline: +1.1%

Memory: ✅ 43.805MB (SLO: <47.000MB -6.8%) vs baseline: +4.9%

✅ add-metrics

Time: ✅ 317.839ms (SLO: <344.800ms -7.8%) vs baseline: +1.2%

Memory: ✅ 652.468MB (SLO: <675.000MB -3.3%) vs baseline: +4.8%

✅ add-tags

Time: ✅ 287.930ms (SLO: <314.000ms -8.3%) vs baseline: +0.6%

Memory: ✅ 652.960MB (SLO: <675.000MB -3.3%) vs baseline: +4.8%

✅ get-context

Time: ✅ 80.135ms (SLO: <92.350ms 📉 -13.2%) vs baseline: +0.3%

Memory: ✅ 39.632MB (SLO: <46.500MB 📉 -14.8%) vs baseline: +4.8%

✅ is-recording

Time: ✅ 38.263ms (SLO: <44.500ms 📉 -14.0%) vs baseline: +1.1%

Memory: ✅ 43.138MB (SLO: <47.500MB -9.2%) vs baseline: +4.9%

✅ record-exception

Time: ✅ 59.151ms (SLO: <67.650ms 📉 -12.6%) vs baseline: +2.0%

Memory: ✅ 39.854MB (SLO: <47.000MB 📉 -15.2%) vs baseline: +4.6%

✅ set-status

Time: ✅ 43.715ms (SLO: <50.400ms 📉 -13.3%) vs baseline: -0.2%

Memory: ✅ 43.212MB (SLO: <47.000MB -8.1%) vs baseline: +4.7%

✅ start

Time: ✅ 38.097ms (SLO: <43.450ms 📉 -12.3%) vs baseline: +2.4%

Memory: ✅ 43.201MB (SLO: <47.000MB -8.1%) vs baseline: +5.0%

✅ start-finish

Time: ✅ 82.129ms (SLO: <88.000ms -6.7%) vs baseline: +0.3%

Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.9%

✅ start-finish-telemetry

Time: ✅ 83.328ms (SLO: <89.000ms -6.4%) vs baseline: ~same

Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.8%

✅ update-name

Time: ✅ 39.723ms (SLO: <45.150ms 📉 -12.0%) vs baseline: +2.8%

Memory: ✅ 43.578MB (SLO: <47.000MB -7.3%) vs baseline: +5.0%

✅ packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 341.676ms (SLO: <354.300ms -3.6%) vs baseline: -0.2%

Memory: ✅ 37.677MB (SLO: <40.000MB -5.8%) vs baseline: +4.7%

✅ cache_on

Time: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.0%

Memory: ✅ 36.511MB (SLO: <39.000MB -6.4%) vs baseline: +6.0%

✅ packagesupdateimporteddependencies - 24/24

✅ import_many

Time: ✅ 154.821µs (SLO: <170.000µs -8.9%) vs baseline: ~same

Memory: ✅ 37.371MB (SLO: <38.500MB -2.9%) vs baseline: +5.8%

✅ import_many_cached

Time: ✅ 121.612µs (SLO: <130.000µs -6.5%) vs baseline: ~same

Memory: ✅ 36.631MB (SLO: <38.500MB -4.9%) vs baseline: +4.9%

✅ import_many_stdlib

Time: ✅ 1.627ms (SLO: <1.750ms -7.0%) vs baseline: +0.2%

Memory: ✅ 37.112MB (SLO: <38.500MB -3.6%) vs baseline: +5.9%

✅ import_many_stdlib_cached

Time: ✅ 0.971ms (SLO: <1.100ms 📉 -11.7%) vs baseline: -0.7%

Memory: ✅ 37.175MB (SLO: <38.500MB -3.4%) vs baseline: +5.1%

✅ import_many_unknown

Time: ✅ 833.705µs (SLO: <890.000µs -6.3%) vs baseline: +0.1%

Memory: ✅ 36.805MB (SLO: <38.500MB -4.4%) vs baseline: +4.2%

✅ import_many_unknown_cached

Time: ✅ 794.113µs (SLO: <870.000µs -8.7%) vs baseline: +0.6%

Memory: ✅ 37.174MB (SLO: <38.500MB -3.4%) vs baseline: +6.0%

✅ import_one

Time: ✅ 19.866µs (SLO: <30.000µs 📉 -33.8%) vs baseline: +0.8%

Memory: ✅ 37.206MB (SLO: <39.000MB -4.6%) vs baseline: +6.8%

✅ import_one_cache

Time: ✅ 6.274µs (SLO: <10.000µs 📉 -37.3%) vs baseline: -0.7%

Memory: ✅ 36.405MB (SLO: <38.500MB -5.4%) vs baseline: +3.5%

✅ import_one_stdlib

Time: ✅ 18.680µs (SLO: <20.000µs -6.6%) vs baseline: -0.1%

Memory: ✅ 36.516MB (SLO: <38.500MB -5.2%) vs baseline: +3.4%

✅ import_one_stdlib_cache

Time: ✅ 6.366µs (SLO: <10.000µs 📉 -36.3%) vs baseline: +1.0%

Memory: ✅ 37.060MB (SLO: <38.500MB -3.7%) vs baseline: +5.3%

✅ import_one_unknown

Time: ✅ 45.394µs (SLO: <50.000µs -9.2%) vs baseline: ~same

Memory: ✅ 36.662MB (SLO: <38.500MB -4.8%) vs baseline: +4.2%

✅ import_one_unknown_cache

Time: ✅ 6.318µs (SLO: <10.000µs 📉 -36.8%) vs baseline: +0.4%

Memory: ✅ 37.073MB (SLO: <38.500MB -3.7%) vs baseline: +5.3%

✅ ratelimiter - 12/12

✅ defaults

Time: ✅ 2.361µs (SLO: <10.000µs 📉 -76.4%) vs baseline: ~same

Memory: ✅ 31.792MB (SLO: <34.000MB -6.5%) vs baseline: +5.0%

✅ high_rate_limit

Time: ✅ 2.420µs (SLO: <10.000µs 📉 -75.8%) vs baseline: ~same

Memory: ✅ 31.752MB (SLO: <34.000MB -6.6%) vs baseline: +4.9%

✅ long_window

Time: ✅ 2.361µs (SLO: <10.000µs 📉 -76.4%) vs baseline: -0.3%

Memory: ✅ 31.772MB (SLO: <34.000MB -6.6%) vs baseline: +4.9%

✅ low_rate_limit

Time: ✅ 2.378µs (SLO: <10.000µs 📉 -76.2%) vs baseline: +0.6%

Memory: ✅ 31.733MB (SLO: <34.000MB -6.7%) vs baseline: +4.7%

✅ no_rate_limit

Time: ✅ 0.829µs (SLO: <10.000µs 📉 -91.7%) vs baseline: -0.3%

Memory: ✅ 31.752MB (SLO: <34.000MB -6.6%) vs baseline: +4.7%

✅ short_window

Time: ✅ 2.503µs (SLO: <10.000µs 📉 -75.0%) vs baseline: +0.2%

Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +5.1%

✅ recursivecomputation - 8/8

✅ deep

Time: ✅ 308.451ms (SLO: <320.950ms -3.9%) vs baseline: +0.1%

Memory: ✅ 32.912MB (SLO: <34.500MB -4.6%) vs baseline: +4.9%

✅ deep-profiled

Time: ✅ 327.373ms (SLO: <359.150ms -8.8%) vs baseline: ~same

Memory: ✅ 37.435MB (SLO: <39.000MB -4.0%) vs baseline: +4.8%

✅ medium

Time: ✅ 7.040ms (SLO: <7.400ms -4.9%) vs baseline: +0.3%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7%

✅ shallow

Time: ✅ 0.945ms (SLO: <1.050ms 📉 -10.0%) vs baseline: -0.2%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ samplingrules - 8/8

✅ average_match

Time: ✅ 137.250µs (SLO: <290.000µs 📉 -52.7%) vs baseline: +0.3%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ high_match

Time: ✅ 173.086µs (SLO: <480.000µs 📉 -63.9%) vs baseline: -0.3%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9%

✅ low_match

Time: ✅ 99.490µs (SLO: <120.000µs 📉 -17.1%) vs baseline: +0.8%

Memory: ✅ 600.851MB (SLO: <700.000MB 📉 -14.2%) vs baseline: +4.8%

✅ very_low_match

Time: ✅ 2.657ms (SLO: <8.500ms 📉 -68.7%) vs baseline: ~same

Memory: ✅ 68.313MB (SLO: <75.000MB -8.9%) vs baseline: +4.9%

✅ sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.505µs (SLO: <20.000µs 📉 -47.5%) vs baseline: ~same

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +5.0%

✅ all-enabled

Time: ✅ 39.955µs (SLO: <50.000µs 📉 -20.1%) vs baseline: -1.3%

Memory: ✅ 32.539MB (SLO: <34.000MB -4.3%) vs baseline: +4.8%

✅ collectipvariant_exists

Time: ✅ 40.518µs (SLO: <50.000µs 📉 -19.0%) vs baseline: -1.2%

Memory: ✅ 32.558MB (SLO: <34.000MB -4.2%) vs baseline: +5.0%

✅ no-collectipvariant

Time: ✅ 39.943µs (SLO: <50.000µs 📉 -20.1%) vs baseline: +0.2%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +4.9%

✅ no-useragentvariant

Time: ✅ 38.687µs (SLO: <50.000µs 📉 -22.6%) vs baseline: -0.3%

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.7%

✅ obfuscation-no-query

Time: ✅ 41.272µs (SLO: <50.000µs 📉 -17.5%) vs baseline: +1.9%

Memory: ✅ 32.539MB (SLO: <34.000MB -4.3%) vs baseline: +5.0%

✅ obfuscation-regular-case-explicit-query

Time: ✅ 75.403µs (SLO: <90.000µs 📉 -16.2%) vs baseline: -0.3%

Memory: ✅ 32.971MB (SLO: <34.000MB -3.0%) vs baseline: +4.9%

✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.282µs (SLO: <90.000µs 📉 -15.2%) vs baseline: +0.2%

Memory: ✅ 32.971MB (SLO: <34.000MB -3.0%) vs baseline: +5.0%

✅ obfuscation-send-querystring-disabled

Time: ✅ 154.057µs (SLO: <170.000µs -9.4%) vs baseline: ~same

Memory: ✅ 32.971MB (SLO: <34.500MB -4.4%) vs baseline: +4.8%

✅ obfuscation-worst-case-explicit-query

Time: ✅ 148.362µs (SLO: <160.000µs -7.3%) vs baseline: +0.3%

Memory: ✅ 32.932MB (SLO: <34.500MB -4.5%) vs baseline: +4.8%

✅ obfuscation-worst-case-implicit-query

Time: ✅ 154.918µs (SLO: <170.000µs -8.9%) vs baseline: +0.3%

Memory: ✅ 32.912MB (SLO: <34.500MB -4.6%) vs baseline: +4.7%

✅ useragentvariant_exists_1

Time: ✅ 40.228µs (SLO: <50.000µs 📉 -19.5%) vs baseline: +1.9%

Memory: ✅ 32.480MB (SLO: <34.000MB -4.5%) vs baseline: +4.6%

✅ useragentvariant_exists_2

Time: ✅ 40.341µs (SLO: <50.000µs 📉 -19.3%) vs baseline: -0.6%

Memory: ✅ 32.519MB (SLO: <34.000MB -4.4%) vs baseline: +4.7%

✅ useragentvariant_exists_3

Time: ✅ 39.943µs (SLO: <50.000µs 📉 -20.1%) vs baseline: -0.6%

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +5.1%

✅ useragentvariant_not_exists_1

Time: ✅ 39.339µs (SLO: <50.000µs 📉 -21.3%) vs baseline: -0.3%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +4.9%

✅ useragentvariant_not_exists_2

Time: ✅ 39.324µs (SLO: <50.000µs 📉 -21.4%) vs baseline: -0.6%

Memory: ✅ 32.617MB (SLO: <34.000MB -4.1%) vs baseline: +5.1%

✅ span - 26/26

✅ add-event

Time: ✅ 20.136ms (SLO: <22.500ms 📉 -10.5%) vs baseline: +1.6%

Memory: ✅ 48.719MB (SLO: <53.000MB -8.1%) vs baseline: +4.7%

✅ add-metrics

Time: ✅ 90.474ms (SLO: <93.500ms -3.2%) vs baseline: +0.9%

Memory: ✅ 735.560MB (SLO: <961.000MB 📉 -23.5%) vs baseline: +4.9%

✅ add-tags

Time: ✅ 146.854ms (SLO: <155.000ms -5.3%) vs baseline: +0.5%

Memory: ✅ 736.129MB (SLO: <962.500MB 📉 -23.5%) vs baseline: +4.9%

✅ get-context

Time: ✅ 18.313ms (SLO: <20.500ms 📉 -10.7%) vs baseline: +0.2%

Memory: ✅ 47.582MB (SLO: <53.000MB 📉 -10.2%) vs baseline: +4.9%

✅ is-recording

Time: ✅ 18.590ms (SLO: <20.500ms -9.3%) vs baseline: +0.5%

Memory: ✅ 47.590MB (SLO: <53.000MB 📉 -10.2%) vs baseline: +5.1%

✅ record-exception

Time: ✅ 38.284ms (SLO: <40.000ms -4.3%) vs baseline: +2.5%

Memory: ✅ 42.000MB (SLO: <53.000MB 📉 -20.8%) vs baseline: +4.8%

✅ set-status

Time: ✅ 20.131ms (SLO: <22.000ms -8.5%) vs baseline: +0.4%

Memory: ✅ 47.609MB (SLO: <53.000MB 📉 -10.2%) vs baseline: +5.0%

✅ start

Time: ✅ 18.317ms (SLO: <20.500ms 📉 -10.6%) vs baseline: +1.1%

Memory: ✅ 47.552MB (SLO: <53.000MB 📉 -10.3%) vs baseline: +4.8%

✅ start-finish

Time: ✅ 50.553ms (SLO: <52.500ms -3.7%) vs baseline: +0.1%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.6%

✅ start-finish-telemetry

Time: ✅ 52.426ms (SLO: <54.500ms -3.8%) vs baseline: +0.8%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ start-finish-traceid128

Time: ✅ 54.105ms (SLO: <57.000ms -5.1%) vs baseline: +0.5%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7%

✅ start-traceid128

Time: ✅ 18.617ms (SLO: <22.500ms 📉 -17.3%) vs baseline: +0.9%

Memory: ✅ 47.527MB (SLO: <53.000MB 📉 -10.3%) vs baseline: +4.7%

✅ update-name

Time: ✅ 18.782ms (SLO: <22.000ms 📉 -14.6%) vs baseline: +0.2%

Memory: ✅ 48.221MB (SLO: <53.000MB -9.0%) vs baseline: +4.9%

✅ tracer - 6/6

✅ large

Time: ✅ 29.394ms (SLO: <32.950ms 📉 -10.8%) vs baseline: -0.1%

Memory: ✅ 32.952MB (SLO: <34.500MB -4.5%) vs baseline: +4.5%

✅ medium

Time: ✅ 2.959ms (SLO: <3.200ms -7.5%) vs baseline: +1.3%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.7%

✅ small

Time: ✅ 329.469µs (SLO: <370.000µs 📉 -11.0%) vs baseline: -0.5%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7%

ℹ️ Scenarios Missing SLO Configuration (9 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

  • coreapiscenario-core_dispatch_listeners
  • coreapiscenario-core_dispatch_no_listeners
  • coreapiscenario-core_dispatch_with_results_listeners
  • coreapiscenario-core_dispatch_with_results_no_listeners
  • djangosimple-baseline
  • errortrackingdjangosimple-baseline
  • errortrackingflasksqli-baseline
  • flasksimple-baseline
  • flasksqli-baseline

@vlad-scherbich vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 3 times, most recently from 195b3c8 to 22f1608 Compare October 10, 2025 18:34
@vlad-scherbich vlad-scherbich changed the title Vlad/lock profiler add rlock feature(profiling): add Reentrant Lock (RLock) support to the Lock profiler Oct 10, 2025
@vlad-scherbich vlad-scherbich changed the title feature(profiling): add Reentrant Lock (RLock) support to the Lock profiler feat(profiling): add Reentrant Lock (RLock) support to the Lock profiler Oct 10, 2025
@vlad-scherbich vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 3 times, most recently from cbe5cdd to a7fb6e2 Compare October 10, 2025 22:11
@vlad-scherbich vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 2 times, most recently from 0520a6b to 4c62a2c Compare October 10, 2025 22:32
@vlad-scherbich vlad-scherbich marked this pull request as ready for review October 10, 2025 22:57
@vlad-scherbich vlad-scherbich requested review from a team as code owners October 10, 2025 22:57
@vlad-scherbich vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 2 times, most recently from 79da982 to 3f50634 Compare October 14, 2025 09:50
@vlad-scherbich vlad-scherbich marked this pull request as draft October 14, 2025 10:03
@vlad-scherbich vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch from 3f50634 to 7e7549f Compare October 14, 2025 14:55
vlad-scherbich
vlad-scherbich commented Oct 14, 2025
View reviewed changes
@vlad-scherbich vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 2 times, most recently from 435e9ec to 5faff64 Compare October 14, 2025 16:08
@vlad-scherbich vlad-scherbich marked this pull request as ready for review October 14, 2025 16:45
@vlad-scherbich
Copy link
Contributor Author

vlad-scherbich commented Oct 15, 2025 •
edited
Loading

One worry i had in mind when doing something similar to this was the fact that some threading classes (Condition, Event) internally use Lock().

Can you share an example of something concerning about this fact? In my view, this is actually a desired effect: complex primitives that use Lock in their implementation, such as Condition and Event, should correctly attribute time spent creating / calling both complex and simple primitives (e.g. by including the calls Lock when creating their underlying class members.)

For Condition and Event, how do you plan to implement the profiler?

I'm still fleshing this out, but given the above statement, I plan to modify _ProfiledLock c-tor so that self._self_init_loc is assigned the actual primitive information, such as: its name and file-lineno.

Example:

cv = threading.Condition()  # app.py:50

cv.wait()    # app.py:75
cv.wait()    # app.py:120
cv.notify()  # app.py:90

Option 1
Would produce something like:

Condition[app.py:50:cv]._lock.wait()@app.py:75
Condition[app.py:50:cv]._lock.wait()@app.py:120
Condition[app.py:50:cv]._lock.notify()@app.py:90

, where [app.py:50:cv] denotes lock creation line, and wait()@app.py:75 shows operation line.

Option 1

In fact, this approach should work for all of the complex primitives that are implemented with either Lock or RLock. As for instrumenting complex primitives' unique methods, such as wait, etc.: it does not seem necessary on the first pass. I think that work should be done in separate PR(s).

Notes
Types implementing Lock (directly and by extension)

Types implementing RLock

@vlad-scherbich vlad-scherbich changed the title feat(profiling): add Reentrant Lock (RLock) support to the Lock profiler feat(profiling): add threading.RLock support to the Lock profiler (re-entrant lock) Oct 16, 2025
taegyunkim
taegyunkim approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@taegyunkim taegyunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks mostly good.

One thing to check

vlad-scherbich and others added 21 commits October 23, 2025 14:56
@vlad-scherbich
feat(profiling): add 'threading.RLock' support to the Lock profiler
e000d93
@vlad-scherbich
add RLock tests
2395cfc
@vlad-scherbich
all TestThreadingLockCollector tests pass; some TestThreadingRLockCol…
66756d9 
…lector tests fail
@vlad-scherbich
some still don't pass; most pass; flaky?
818e62a
@vlad-scherbich
fix lints
22baef3
@vlad-scherbich
rm unnecessary 'pass'
5c6484c
@vlad-scherbich
fix test_global_locks test
93ea186
@vlad-scherbich
Simplified and improve: fix test_global_locks test
8fdbd8d
@vlad-scherbich
lint fixes
e7e659a
@vlad-scherbich
fix line-number discrepancy for py versions
197f883
@vlad-scherbich
Add a release note
b465fe2
@vlad-scherbich
add e2e test
28dc94b
@vlad-scherbich
fix lint
7ba5c16
@vlad-scherbich
move the e2e test file into tests dir
fa05ae3
@vlad-scherbich
adding more tests
0b47089
@vlad-scherbich
Moving test_user_threads_have_native_id to test_profiler (it doesn't …
1038886 
…belong with threading)
@vlad-scherbich
Clean up 'test_[r|]lock_gevent_tasks' tests
6c2461f
@vlad-scherbich
fix tests (import threading)
7d2dcf1
@vlad-scherbich @taegyunkim
Update ddtrace/profiling/collector/threading.py
39bc88f 
Co-authored-by: Taegyun Kim <[email protected]>
@vlad-scherbich @taegyunkim
Update ddtrace/profiling/collector/threading.py
bfe6b84 
Co-authored-by: Taegyun Kim <[email protected]>
@vlad-scherbich
fix tests and rm the e2e test file
f29be5c
@vlad-scherbich vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch from 45abc7f to f29be5c Compare October 23, 2025 18:56
@vlad-scherbich
Copy link
Contributor Author

vlad-scherbich commented Oct 23, 2025 •
edited
Loading

The PR looks mostly good.

One thing to check

@taegyunkim , as we've discussed offline, there's a bug in the Thread Timeline view that prevents Lock events form being displayed. They are being captured, however, as we've discovered. For more details, see this ticket: https://datadoghq.atlassian.net/browse/PROF-12837

However, I can demonstrate that RLock samples are flowing from my machine to prod: Flame Graph view

image

@vlad-scherbich vlad-scherbich merged commit 11f3bd9 into main Oct 24, 2025
493 checks passed
@vlad-scherbich vlad-scherbich deleted the vlad/lock-profiler-add-rlock branch October 24, 2025 12:53
@vlad-scherbich vlad-scherbich mentioned this pull request Nov 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmettbutler emmettbutler emmettbutler approved these changes

@taegyunkim taegyunkim taegyunkim approved these changes

@danielsn danielsn Awaiting requested review from danielsn

@wconti27 wconti27 Awaiting requested review from wconti27 wconti27 is a code owner automatically assigned from DataDog/apm-python

@mabdinur mabdinur Awaiting requested review from mabdinur mabdinur is a code owner automatically assigned from DataDog/apm-python

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vlad-scherbich @emmettbutler @taegyunkim